Title: Add ERC2612 Permit Security Checklist Items#40
Open
rocknwa wants to merge 1 commit intoCyfrin:mainfrom
Open
Title: Add ERC2612 Permit Security Checklist Items#40rocknwa wants to merge 1 commit intoCyfrin:mainfrom
rocknwa wants to merge 1 commit intoCyfrin:mainfrom
Conversation
Add two critical security validation items for ERC2612 permit implementations: - Zero address validation after ecrecover (SOL-Token-FE-17) - DOMAIN_SEPARATOR chain split protection (SOL-Token-FE-18) These additions expand permit security coverage beyond the existing DOMAIN_SEPARATOR implementation check (SOL-Token-FE-11).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive security checks for ERC2612 permit implementations,
expanding on the existing SOL-Token-FE-11 item. The new checks cover:
These additions address critical permit-specific vulnerabilities that are
currently underrepresented in the fungible token security checklist.